FM10K/dpdk-fm10k
FM10K/dpdk-fm10k
1
0
Fork 0
Code Issues Pull requests Releases Activity

common/octeontx2: retry interrupt callback unregister

Browse source 
Interrupt callback unregister can fail with -EAGAIN
when interrupt handler is active in interrupt thread.
Hence retry before reporting a failure or proceeding further.

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
This commit is contained in:
Nithin Dabilpuram 2020-06-11 12:56:04 +05:30 committed by Ferruh Yigit
parent 112510aece
commit ff46ba7385
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
drivers/common/octeontx2/otx2_irq.c
View file

@ -193,6 +193,8 @@ otx2_unregister_irq(struct rte_intr_handle *intr_handle,
rte_intr_callback_fn cb, void *data, unsigned int vec)
{
struct rte_intr_handle tmp_handle;
uint8_t retries = 5; /* 5 ms */
int rc;
if (vec > intr_handle->max_intr) {
otx2_err("Error unregistering MSI-X interrupts vec:%d > %d",
@ -205,8 +207,21 @@ otx2_unregister_irq(struct rte_intr_handle *intr_handle,
if (tmp_handle.fd == -1)
return;
/* Un-register callback func from eal lib */
rte_intr_callback_unregister(&tmp_handle, cb, data);
do {
/* Un-register callback func from eal lib */
rc = rte_intr_callback_unregister(&tmp_handle, cb, data);
/* Retry only if -EAGAIN */
if (rc != -EAGAIN)
break;
rte_delay_ms(1);
retries--;
} while (retries);
if (rc < 0) {
otx2_err("Error unregistering MSI-X intr vec %d cb, rc=%d",
vec, rc);
return;
}
otx2_base_dbg("Disable vector:0x%x for vfio (efds: %d, max:%d)",
vec, intr_handle->nb_efd, intr_handle->max_intr);