P2Pool/consensus
P2Pool/consensus
1
1
Fork 0
Code Issues 3 Pull requests Releases Activity

Do not allow empty spend and view pubkeys in side data

Browse source
This commit is contained in:
DataHoarder 2023-06-05 23:44:54 +02:00
parent 03ff13fc0c
commit 209decd5b7
Signed by: DataHoarder
SSH key fingerprint: SHA256:OLTRf6Fl87G52SiR7sWLGNzlJt4WOX+tfI2yxo0z7xk
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
p2pool/sidechain/sidedata.go
View file

@ -3,6 +3,7 @@ package sidechain
import (
"bytes"
"encoding/binary"
"errors"
"fmt"
"git.gammaspectra.live/P2Pool/p2pool-observer/monero/crypto"
p2pooltypes "git.gammaspectra.live/P2Pool/p2pool-observer/p2pool/types"
@ -88,6 +89,11 @@ func (b *SideData) FromReader(reader utils.ReaderAndByteReader, version ShareVer
if _, err = io.ReadFull(reader, b.PublicViewKey[:]); err != nil {
return err
}
var emptyKey crypto.PublicKeyBytes
if b.PublicSpendKey == emptyKey && b.PublicViewKey == emptyKey {
return errors.New("both spend and view key are zero")
}
if version > ShareVersion_V1 {
//needs preprocessing
if _, err = io.ReadFull(reader, b.CoinbasePrivateKeySeed[:]); err != nil {