From bb285131fc885e21100a1603fec20ad3bf8a0589 Mon Sep 17 00:00:00 2001
From: WeebDataHoarder <57538841+WeebDataHoarder@users.noreply.github.com>
Date: Sun, 25 Feb 2024 19:43:39 +0100
Subject: [PATCH] Remove last usages of ReverseSlice

---
 cmd/utils/position_chart.go       | 31 ++++++++++++++++++-------------
 utils/{slice.go => nthelement.go} |  7 -------
 2 files changed, 18 insertions(+), 20 deletions(-)
 rename utils/{slice.go => nthelement.go} (96%)

diff --git a/cmd/utils/position_chart.go b/cmd/utils/position_chart.go
index 0bc8739..4ca7b7d 100644
--- a/cmd/utils/position_chart.go
+++ b/cmd/utils/position_chart.go
@@ -1,10 +1,5 @@
 package utils
 
-import (
-	"git.gammaspectra.live/P2Pool/p2pool-observer/utils"
-	"slices"
-)
-
 type PositionChart struct {
 	totalItems uint64
 	bucket     []uint64
@@ -56,7 +51,10 @@ func (p *PositionChart) String() string {
 	position := make([]byte, 2*2+len(p.bucket))
 	position[0], position[1] = '[', '<'
 	position[len(position)-2], position[len(position)-1] = '<', ']'
-	for i, e := range utils.ReverseSlice(slices.Clone(p.bucket)) {
+
+	//reverse
+	for i := len(p.bucket) - 1; i >= 0; i-- {
+		e := p.bucket[i]
 		if e > 0 {
 			if e > 9 {
 				position[2+i] = '+'
@@ -73,7 +71,10 @@ func (p *PositionChart) String() string {
 
 func (p *PositionChart) StringWithoutDelimiters() string {
 	position := make([]byte, len(p.bucket))
-	for i, e := range utils.ReverseSlice(slices.Clone(p.bucket)) {
+
+	//reverse
+	for i := len(p.bucket) - 1; i >= 0; i-- {
+		e := p.bucket[i]
 		if e > 0 {
 			if e > 9 {
 				position[i] = '+'
@@ -97,18 +98,22 @@ func (p *PositionChart) StringWithSeparator(index int) string {
 	position[0], position[1] = '[', '<'
 	position[2+separatorIndex] = '|'
 	position[len(position)-2], position[len(position)-1] = '<', ']'
-	for i, e := range utils.ReverseSlice(slices.Clone(p.bucket)) {
-		if i >= separatorIndex {
-			i++
+
+	//reverse
+	for i := len(p.bucket) - 1; i >= 0; i-- {
+		e := p.bucket[i]
+		j := i
+		if j >= separatorIndex {
+			j++
 		}
 		if e > 0 {
 			if e > 9 {
-				position[2+i] = '+'
+				position[2+j] = '+'
 			} else {
-				position[2+i] = 0x30 + byte(e)
+				position[2+j] = 0x30 + byte(e)
 			}
 		} else {
-			position[2+i] = p.idle
+			position[2+j] = p.idle
 		}
 	}
 
diff --git a/utils/slice.go b/utils/nthelement.go
similarity index 96%
rename from utils/slice.go
rename to utils/nthelement.go
index 8bf5cba..bcc2a86 100644
--- a/utils/slice.go
+++ b/utils/nthelement.go
@@ -2,15 +2,8 @@ package utils
 
 import (
 	"cmp"
-	"slices"
 )
 
-func ReverseSlice[S ~[]E, E any](s S) S {
-	slices.Reverse(s)
-
-	return s
-}
-
 // NthElementSlice QuickSelect implementation
 // k is the desired index value, where array[k] is the k+1 smallest element
 // values between s[0, k-1] are guaranteed <= to s[k]