16197b4051
The edwards25519 tests can be quite slow on platforms without a well-optimized implementation, especially if the race detector is also enabled. Since these tests aren't checking for specific inputs anyway, the extra coverage of a more aggressive quick.Config does not seem worth wasting extra time on slow CI builders and TryBots. For #60109. Change-Id: I530e75a0b76725585df5a2f5ded6705ab1b9da51 Reviewed-on: https://go-review.googlesource.com/c/go/+/522715 Reviewed-by: Filippo Valsorda <filippo@golang.org> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Joedian Reid <joedian@golang.org>
112 lines
3.1 KiB
Go
112 lines
3.1 KiB
Go
// Copyright (c) 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package edwards25519
|
|
|
|
import (
|
|
"testing"
|
|
"testing/quick"
|
|
)
|
|
|
|
func TestScalarAliasing(t *testing.T) {
|
|
checkAliasingOneArg := func(f func(v, x *Scalar) *Scalar, v, x Scalar) bool {
|
|
x1, v1 := x, x
|
|
|
|
// Calculate a reference f(x) without aliasing.
|
|
if out := f(&v, &x); out != &v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Test aliasing the argument and the receiver.
|
|
if out := f(&v1, &v1); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Ensure the arguments was not modified.
|
|
return x == x1
|
|
}
|
|
|
|
checkAliasingTwoArgs := func(f func(v, x, y *Scalar) *Scalar, v, x, y Scalar) bool {
|
|
x1, y1, v1 := x, y, Scalar{}
|
|
|
|
// Calculate a reference f(x, y) without aliasing.
|
|
if out := f(&v, &x, &y); out != &v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Test aliasing the first argument and the receiver.
|
|
v1 = x
|
|
if out := f(&v1, &v1, &y); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
// Test aliasing the second argument and the receiver.
|
|
v1 = y
|
|
if out := f(&v1, &x, &v1); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Calculate a reference f(x, x) without aliasing.
|
|
if out := f(&v, &x, &x); out != &v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Test aliasing the first argument and the receiver.
|
|
v1 = x
|
|
if out := f(&v1, &v1, &x); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
// Test aliasing the second argument and the receiver.
|
|
v1 = x
|
|
if out := f(&v1, &x, &v1); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
// Test aliasing both arguments and the receiver.
|
|
v1 = x
|
|
if out := f(&v1, &v1, &v1); out != &v1 || v1 != v || !isReduced(out.Bytes()) {
|
|
return false
|
|
}
|
|
|
|
// Ensure the arguments were not modified.
|
|
return x == x1 && y == y1
|
|
}
|
|
|
|
for name, f := range map[string]interface{}{
|
|
"Negate": func(v, x Scalar) bool {
|
|
return checkAliasingOneArg((*Scalar).Negate, v, x)
|
|
},
|
|
"Invert": func(v, x Scalar) bool {
|
|
return checkAliasingOneArg((*Scalar).Invert, v, x)
|
|
},
|
|
"Multiply": func(v, x, y Scalar) bool {
|
|
return checkAliasingTwoArgs((*Scalar).Multiply, v, x, y)
|
|
},
|
|
"Add": func(v, x, y Scalar) bool {
|
|
return checkAliasingTwoArgs((*Scalar).Add, v, x, y)
|
|
},
|
|
"Subtract": func(v, x, y Scalar) bool {
|
|
return checkAliasingTwoArgs((*Scalar).Subtract, v, x, y)
|
|
},
|
|
"MultiplyAdd1": func(v, x, y, fixed Scalar) bool {
|
|
return checkAliasingTwoArgs(func(v, x, y *Scalar) *Scalar {
|
|
return v.MultiplyAdd(&fixed, x, y)
|
|
}, v, x, y)
|
|
},
|
|
"MultiplyAdd2": func(v, x, y, fixed Scalar) bool {
|
|
return checkAliasingTwoArgs(func(v, x, y *Scalar) *Scalar {
|
|
return v.MultiplyAdd(x, &fixed, y)
|
|
}, v, x, y)
|
|
},
|
|
"MultiplyAdd3": func(v, x, y, fixed Scalar) bool {
|
|
return checkAliasingTwoArgs(func(v, x, y *Scalar) *Scalar {
|
|
return v.MultiplyAdd(x, y, &fixed)
|
|
}, v, x, y)
|
|
},
|
|
} {
|
|
err := quick.Check(f, quickCheckConfig(32))
|
|
if err != nil {
|
|
t.Errorf("%v: %v", name, err)
|
|
}
|
|
}
|
|
}
|