flac: fix golangci metalint issues

.travis.yml

@@ -26,6 +26,6 @@ before_script:
 
 script:
   - ./goclean.sh
-  - golangci-lint run --enable-all --disable maligned --exclude "(G501:|Error return value of .md5sum\.Write. is not checked)"
+  - golangci-lint run --enable-all --disable maligned,lll,dupl --exclude "(G501:|G401:|Error return value of .md5sum\.Write. is not checked)"
 
 # skip G501: Import blacklist: crypto/md5

internal/bits/reader_test.go

@@ -646,7 +646,10 @@ func benchmarkReads(b *testing.B, chunk, align int) {
 	for i := 0; i < b.N; i++ {
 		r := NewReader(bytes.NewReader(buf))
 		for j := 0; j < last; j++ {
-			r.Read(bits[j])
+			if _, err := r.Read(bits[j]); err != nil {
+				b.Error(err)
+				continue
+			}
 		}
 	}
 }

internal/hashutil/crc16/crc16_test.go

@@ -48,7 +48,10 @@ var golden = []test{
 func TestCrc16IBM(t *testing.T) {
 	for _, g := range golden {
 		h := NewIBM()
-		io.WriteString(h, g.in)
+		if _, err := io.WriteString(h, g.in); err != nil {
+			t.Error(err)
+			continue
+		}
 		got := h.Sum16()
 		if got != g.want {
 			t.Errorf("IBM(%q); expected 0x%04X, got 0x%04X.", g.in, g.want, got)
@@ -94,7 +97,10 @@ func benchmarkCrc16(b *testing.B, count int64) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		h.Reset()
-		h.Write(data)
+		if _, err := h.Write(data); err != nil {
+			b.Error(err)
+			continue
+		}
 		h.Sum(in)
 	}
 }

internal/hashutil/crc8/crc8_test.go

@@ -48,7 +48,10 @@ var golden = []test{
 func TestCrc8ATM(t *testing.T) {
 	for _, g := range golden {
 		h := NewATM()
-		io.WriteString(h, g.in)
+		if _, err := io.WriteString(h, g.in); err != nil {
+			t.Error(err)
+			continue
+		}
 		got := h.Sum8()
 		if got != g.want {
 			t.Errorf("ATM(%q); expected 0x%02X, got 0x%02X.", g.in, g.want, got)
@@ -94,7 +97,10 @@ func benchmarkCrc8(b *testing.B, count int64) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		h.Reset()
-		h.Write(data)
+		if _, err := h.Write(data); err != nil {
+			b.Error(err)
+			continue
+		}
 		h.Sum(in)
 	}
 }

meta/meta.go

@@ -31,7 +31,6 @@ import (
 	"errors"
 	"io"
 	"io/ioutil"
-	"os"
 
 	"github.com/mewkiz/flac/internal/bits"
 )
@@ -109,7 +108,7 @@ func (block *Block) Parse() error {
 // Skip ignores the contents of the metadata block body.
 func (block *Block) Skip() error {
 	if sr, ok := block.lr.(io.Seeker); ok {
-		_, err := sr.Seek(0, os.SEEK_END)
+		_, err := sr.Seek(0, io.SeekEnd)
 		return err
 	}
 	_, err := io.Copy(ioutil.Discard, block.lr)