S.O.N.G/flacgo
S.O.N.G/flacgo
3
0
Fork 0
Code Issues Pull requests Releases Activity

cmd/go-metaflac: simplify control flow

Browse source 
Fix issue reported by megacheck:

cmd/go-metaflac/metaflac.go:82:2: unnecessary nil check around range (megacheck)
	if blockNums != nil {
	^

Updates #25.
This commit is contained in:
mewmew 2018-05-27 14:31:49 +02:00
parent 95b4b1d046
commit 6d39a798cb
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
cmd/go-metaflac/metaflac.go
View file

@ -79,22 +79,8 @@ func list(path string) error {
return err
}
if blockNums != nil {
// Only list blocks specified in the "--block-number" command line flag.
for _, blockNum := range blockNums {
if blockNum == 0 {
listStreamInfo(stream.Info)
} else {
// strea.Blocks doesn't contain StreamInfo, therefore the blockNum
// is one less.
blockNum--
}
if blockNum < len(stream.Blocks) {
listBlock(stream.Blocks[blockNum], blockNum)
}
}
} else {
// List all blocks.
// List all blocks.
if blockNums == nil {
var isLast bool
if len(stream.Blocks) == 0 {
isLast = true
@ -107,8 +93,22 @@ func list(path string) error {
blockNum--
listBlock(block, blockNum)
}
return nil
}
// Only list blocks specified in the "--block-number" command line flag.
for _, blockNum := range blockNums {
if blockNum == 0 {
listStreamInfo(stream.Info)
} else {
// strea.Blocks doesn't contain StreamInfo, therefore the blockNum
// is one less.
blockNum--
}
if blockNum < len(stream.Blocks) {
listBlock(stream.Blocks[blockNum], blockNum)
}
}
return nil
}