WeebDataHoarder/Av1an
WeebDataHoarder/Av1an
1
0
Fork 0
Code Issues Pull requests Releases Activity

Fix a case where the log file could fail to be created (#409)

Browse source 
Previously, these warn statements came before we create
the temp directory. I'm assuming when the first log
statement is run, flexi_logger then attempts to create
the log file. If it fails, it doesn't try again.

Ensuring we create the temp directory before attempting
to log should resolve this issue.
This commit is contained in:
Josh Holmer 2021-11-17 19:07:42 -05:00 committed by GitHub
parent f94c65f992
commit b10cb6e7cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
av1an-core/src/settings.rs
View file

@ -101,6 +101,17 @@ impl EncodeArgs {
ffmpeg_next::init()?;
ffmpeg_next::util::log::set_level(ffmpeg_next::util::log::level::Level::Fatal);
if !self.resume && Path::new(&self.temp).is_dir() {
fs::remove_dir_all(&self.temp)
.with_context(|| format!("Failed to remove temporary directory {:?}", &self.temp))?;
}
create_dir!(Path::new(&self.temp))?;
create_dir!(Path::new(&self.temp).join("split"))?;
create_dir!(Path::new(&self.temp).join("encode"))?;
info!("temporary directory: {}", &self.temp);
let done_json_exists = Path::new(&self.temp).join("done.json").exists();
let chunks_json_exists = Path::new(&self.temp).join("chunks.json").exists();
@ -132,17 +143,6 @@ impl EncodeArgs {
}
}
if !self.resume && Path::new(&self.temp).is_dir() {
fs::remove_dir_all(&self.temp)
.with_context(|| format!("Failed to remove temporary directory {:?}", &self.temp))?;
}
create_dir!(Path::new(&self.temp))?;
create_dir!(Path::new(&self.temp).join("split"))?;
create_dir!(Path::new(&self.temp).join("encode"))?;
info!("temporary directory: {}", &self.temp);
Ok(())
}