pwgen2155/dawdle
pwgen2155/dawdle
1
0
Fork 2
Code Issues 10 Pull requests Packages Activity

todo: cleanup readme & initial config #12

New issue
Closed
opened 2024-03-04 11:03:33 +00:00 by pwgen2155 · 5 comments
pwgen2155 commented 2024-03-04 11:03:33 +00:00
Owner
Copy link
  • fix readme to ensure people can actually understand what to do
  • update dockerfiles to use dev first and override in prod
  • update site/settings.py to use dev first too
  • dont make --setup force you to enter items but read config?
- [x] fix readme to ensure people can actually understand what to do - [x] update dockerfiles to use dev first and override in prod - [x] update site/settings.py to use dev first too - [x] dont make --setup force you to enter items but read config?
Mediaman commented 2024-03-04 17:13:22 +00:00
Contributor
Copy link

A few questions

What exactly do you mean by "use dev first"?

For the last item, should we make it automatically create a character with the name in the owner field with a default password to be changed on login? Or what approach should we take to this?

As for the readme and setup, am I crazy in wanting to remove install.sh since most of it is unnecessary for how our version runs in docker and just walk through the few necessary commands in the readme?

A few questions What exactly do you mean by "use dev first"? For the last item, should we make it automatically create a character with the name in the owner field with a default password to be changed on login? Or what approach should we take to this? As for the readme and setup, am I crazy in wanting to remove install.sh since most of it is unnecessary for how our version runs in docker and just walk through the few necessary commands in the readme?
pwgen2155 commented 2024-03-04 22:37:33 +00:00
Author
Owner
Copy link

What exactly do you mean by "use dev first"?

you can have two files docker-compose.yml and docker-compose.prod.yml files. and then you call docker like docker compose -f docker-compose.yml -f docker-compose.prod.yml up -d. (When in prod) then in dev its the standard docker compose up -d

ref: https://docs.docker.com/compose/multiple-compose-files/extends/

automatically create a character with the name in the owner field with a default password

If we could make it a random password and print to log that'd probably be acceptable, is that all we'd have to do for setup? I keep using the old db, (which as i've found out, PM's everyone, so i'll have to stop that.....)

remove install.sh

I only left it because we hadn't documented everything yet. 100% removing this nonsense as well as possibly everything in setup as we've dockerised everything

> What exactly do you mean by "use dev first"? you can have two files docker-compose.yml and docker-compose.prod.yml files. and then you call docker like `docker compose -f docker-compose.yml -f docker-compose.prod.yml up -d`. (When in prod) then in dev its the standard docker compose up -d ref: https://docs.docker.com/compose/multiple-compose-files/extends/ ---------- > automatically create a character with the name in the owner field with a default password If we could make it a random password and print to log that'd probably be acceptable, is that all we'd have to do for setup? I keep using the old db, (which as i've found out, PM's everyone, so i'll have to stop that.....) ---------- > remove install.sh I only left it because we hadn't documented everything yet. 100% removing this nonsense as well as possibly everything in setup as we've dockerised everything
Mediaman commented 2024-03-06 04:55:07 +00:00
Contributor
Copy link

Probably gonna leave the docker-compose files to you as you've more experience with docker than me and also know more how you want that set up than I do

is that all we'd have to do for setup?

I think so? It does need a character class, but I can set it to a default like "Hidden Master" or smth since admins have a command to change class anyway if they want to.

Probably gonna leave the docker-compose files to you as you've more experience with docker than me and also know more how you want that set up than I do >is that all we'd have to do for setup? I think so? It does need a character class, but I can set it to a default like "Hidden Master" or smth since admins have a command to change class anyway if they want to.
👍 1
Mediaman commented 2024-03-06 06:13:25 +00:00
Contributor
Copy link

pwgen2155/dawdle#15

A PR for fixing the readme (as well as general setup stuff) and simplifying --setup

Tested following the exact instructions I wrote from a fresh clone of the repo and it works, only caveat being that it seems to need a docker compose restart before the /players and /quests pages will work

pwgen2155/dawdle#15 A PR for fixing the readme (as well as general setup stuff) and simplifying --setup Tested following the exact instructions I wrote from a fresh clone of the repo and it works, only caveat being that it seems to need a docker compose restart before the /players and /quests pages will work
pwgen2155 commented 2024-03-21 09:48:34 +00:00
Author
Owner
Copy link

Fixed: fbc3261f45

Fixed: fbc3261f458d15ed635855e2442c5b1c53649ded
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
penalties
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pwgen2155/dawdle#12
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?