Addition of plugins and VapourSynth update #1

Open
opened 2023-05-21 10:33:03 +00:00 by abcnorio · 6 comments

Dear weebdatahoarder,

is it possible to clone this repo to your github account? I tweaked this to work with a more recent version of vapoursynth along with bas (best audio source). But it is not possible to fork on github from gammaspectra.

thx.

Dear weebdatahoarder, is it possible to clone this repo to your github account? I tweaked this to work with a more recent version of vapoursynth along with bas (best audio source). But it is not possible to fork on github from gammaspectra. thx.
Owner

Hey! Do you have a link to the repository? I can create a tracking PR here

Hey! Do you have a link to the repository? I can create a tracking PR here
Owner

(or, if you have a .patch file alternatively, that could be nice as well)

(or, if you have a .patch file alternatively, that could be nice as well)
DataHoarder self-assigned this 2023-05-21 18:11:46 +00:00
Author

yes sure, give me some days time, I am new to "git". vapoursynth is R55. You'll get the repo name on github and patch files for the dockerfile and the vapoursynth addon builds. Your already present addons (version numbers) are untouched as they still worked. All in all that's really great, with the docker engine the frameserver works headless remotely.

yes sure, give me some days time, I am new to "git". vapoursynth is R55. You'll get the repo name on github and patch files for the dockerfile and the vapoursynth addon builds. Your already present addons (version numbers) are untouched as they still worked. All in all that's really great, with the docker engine the frameserver works headless remotely.
Author

The repo will be

https://github.com/abcnorio/docker-vapoursynth-encoder

(it is not yet made public but exists)

Patch files are attached for:

Dockerfile
docker/build/vapoursynth-plugins/build.sh

Hope that's ok that way. Originally new plugins were separately in a unique folder + its own build.sh while working on it. This is now merged with the existent build.sh.

New plugins are at the end, so easy to distinguish from your previous work. Vapoursynth was changed from R54 to R55. That's the first that supports audio input.

Docker built worked for me (on a Debian OS).

Being new to git - what is best practice? Clone your repo from gammaspectra, insert changes and push to the github repo - however it cannot be labeled as a fork there if I understood it properly. So will add a link to your repo. Ok that way?

The repo will be https://github.com/abcnorio/docker-vapoursynth-encoder (it is not yet made public but exists) Patch files are attached for: Dockerfile docker/build/vapoursynth-plugins/build.sh Hope that's ok that way. Originally new plugins were separately in a unique folder + its own build.sh while working on it. This is now merged with the existent build.sh. New plugins are at the end, so easy to distinguish from your previous work. Vapoursynth was changed from R54 to R55. That's the first that supports audio input. Docker built worked for me (on a Debian OS). Being new to git - what is best practice? Clone your repo from gammaspectra, insert changes and push to the github repo - however it cannot be labeled as a fork there if I understood it properly. So will add a link to your repo. Ok that way?
Owner

I have pushed a few changes - specifically now you can pick either VapourSynth API3 or API4 based versions. Old API3 has been left as-is, besides upgrading to specifically R55-API3. API4 is untested atm but that has been upgraded to R62 (R63 has issues on clang)

Some scripts on the API4 section have been changed, I will otherwise review your whole new list of plugins.

I have pushed a few changes - specifically now you can pick either VapourSynth API3 or API4 based versions. Old API3 has been left as-is, besides upgrading to specifically R55-API3. API4 is untested atm but that has been upgraded to R62 (R63 has issues on clang) Some scripts on the API4 section have been changed, I will otherwise review your whole new list of plugins.
Owner

As of 5ee273cbf0 this has the other plugins you listed on the original patch (and a few more), minus OpenCL ones. You can have an extra multi-stage build for adding OpenCL plugins:

DOCKER_BUILDKIT=1 docker build -t encoder-vapoursynth4-plugins --target encoder-vapoursynth4-plugins .

Then on your own Dockerfile you can use it as a base:

FROM encoder-vapoursynth4-plugins
[...]
As of 5ee273cbf0a99034dd4a183b4a41be7d21fa5f2b this has the other plugins you listed on the original patch (and a few more), minus OpenCL ones. You can have an extra multi-stage build for adding OpenCL plugins: ```bash DOCKER_BUILDKIT=1 docker build -t encoder-vapoursynth4-plugins --target encoder-vapoursynth4-plugins . ``` Then on your own Dockerfile you can use it as a base: ``` FROM encoder-vapoursynth4-plugins [...] ```
DataHoarder changed title from clone to git to Addition of plugins and VapourSynth update 2023-08-22 04:50:49 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: WeebDataHoarder/encoder#1
No description provided.